You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I was fixing flakyness through these tests after them failing on the CI, it took me longer than expected to understand which test was failing, and those were tests I had written myself. Concerned about other people having to maintain these tests, I decided to reorganize them in hope of making it clearer to understand what each test does 'at a glance'.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
…cture
doc: update the descriptions of the multchain e2e tests for greater clarity
refactor: update file names to include permission-system
update imports
refactor: move the inititial connect test with other network tests
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EtherWizard33
added
Run Smoke E2E
metamaskbot
added
the
release-7.39.0
Description
As I was fixing flakyness through these tests after them failing on the CI, it took me longer than expected to understand which test was failing, and those were tests I had written myself. Concerned about other people having to maintain these tests, I decided to reorganize them in hope of making it clearer to understand what each test does 'at a glance'.
Related issues
Fixes:
Manual testing steps
yarn watch:cleanyarn test:e2e:ios:debug:buildyarn test:e2e:ios:debug:run <path to test file>Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist