Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set token network filter when adding network from dapp #12661

Merged
merged 5 commits into from
Dec 19, 2024
Merged

fix: set token network filter when adding network from dapp #12661

merged 5 commits into from
Dec 19, 2024
+62 −2

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Dec 12, 2024 •
edited
Loading

Description

PR to setTokenNetworkFilter value when user is adding a new network from dapp

Related issues

Fixes:

Manual testing steps

  1. Click on current network
  2. Add new network from chainlist
  3. Confirm switching to this network
  4. Go back to wallet and you should see your new network with the correct token list

Screenshots/Recordings

Before

Screen.Recording.2024-12-12.at.17.24.09.mov

After

Screen.Recording.2024-12-12.at.18.43.09.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7c40d5a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2a363eb6-01e6-4b2c-bbd0-9dab112c35fe

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d7fda73
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9a6aa4eb-47d7-4ff8-9870-051f42582577

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review December 12, 2024 17:47
@sahar-fehri sahar-fehri requested a review from a team as a code owner December 12, 2024 17:47
vinnyhoward
vinnyhoward previously approved these changes Dec 12, 2024
View reviewed changes
bergeron
bergeron previously approved these changes Dec 12, 2024
View reviewed changes
Daniel-Cross
Daniel-Cross previously approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c93e88a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5136365-1dfd-48c8-ab73-957ba92f5520

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 13, 2024
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 16, 2024
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dd29c01
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d385959-55d1-4907-968d-3467980ba433

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@salimtb
Copy link
Contributor

salimtb commented Dec 19, 2024

tested and approved ✅

@sahar-fehri sahar-fehri added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 425669e Dec 19, 2024
40 checks passed
@sahar-fehri sahar-fehri deleted the fix/set-token-network-filter-when-adding-custom-network branch December 19, 2024 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Daniel-Cross Daniel-Cross Daniel-Cross approved these changes

@salimtb salimtb salimtb approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@vinnyhoward vinnyhoward vinnyhoward left review comments

@bergeron bergeron bergeron left review comments

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sahar-fehri @salimtb @bergeron @OGPoyraz @vinnyhoward @Daniel-Cross @metamaskbot