Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metametricsid in state export #12621

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Dec 10, 2024

Description

Add metaMetrics ID in state export (export on long press on login screen fox)

Related issues

Fixes #12541

Manual testing steps

Feature: Add metaMetrics ID in state export

  Scenario: User opted-in for metametrics
    Given app is installed and wallet created
    And user opted-in for metametrics
    And user is on login screen
    When user long press the fox logo (>10s)
    Then download state file starts
    And the file has metaMetricsId value in it.

  Scenario: User did not opt-in or opted-out for metametrics
    Given app is installed and wallet created
    And user did not opt-in or opted-out for metametrics
    And user is on login screen
    When user long press the fox logo (>10s)
    Then download state file starts
    And the file does not have metaMetricsId value in it.

Screenshots/Recordings

Before

N/A

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NicolasMassart NicolasMassart self-assigned this Dec 10, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart marked this pull request as ready for review December 10, 2024 14:58
@NicolasMassart NicolasMassart requested a review from a team as a code owner December 10, 2024 14:58
@NicolasMassart NicolasMassart added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 10, 2024
Copy link
Contributor

github-actions bot commented Dec 10, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 01f6e20
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dc761972-e5ec-4256-9026-d3d2ada3ac22

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@NicolasMassart NicolasMassart marked this pull request as draft December 10, 2024 19:23
auto-merge was automatically disabled December 10, 2024 19:23

Pull request was converted to draft

@NicolasMassart NicolasMassart marked this pull request as ready for review December 11, 2024 16:03
@NicolasMassart NicolasMassart added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: efeb05e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28e89ada-3d00-4927-865c-10af06a5a433

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.67%. Comparing base (da4021c) to head (b80d71f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12621      +/-   ##
==========================================
- Coverage   58.69%   58.67%   -0.02%     
==========================================
  Files        1847     1847              
  Lines       41629    41634       +5     
  Branches     5370     5374       +4     
==========================================
- Hits        24433    24429       -4     
- Misses      15528    15529       +1     
- Partials     1668     1676       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasMassart NicolasMassart added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 30e8f6d Dec 13, 2024
36 checks passed
@NicolasMassart NicolasMassart deleted the feat/12541_metametrics_id_in_state branch December 13, 2024 11:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: move metametricsId to state
4 participants