Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace end of navigation init and UIStartup span #12489

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 28, 2024

Description

Replace navigation init and UIStartup Span

  • It seems that the span was ending in the finally of appTriggeredAuth, which means that it was ending after Byometrics of the user which was causing this issue (5 minutes long span)

  • Moving it to an useEffect that will only trigger the end of the span when the navigator is defined and there is no prevNavigator ref will means that the traces will end when the biometrics are actually triggered instead of when it is completed

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-tiger Tiger team (for tech debt reduction + performance improvements) labels Nov 28, 2024
@tommasini tommasini requested a review from a team as a code owner November 28, 2024 21:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Nov 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8330e67
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6eba64c-8be6-4b95-86f4-cef484355cf6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommasini tommasini added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 6fa4752 Nov 28, 2024
55 checks passed
@tommasini tommasini deleted the fix/ui-startup-span branch November 28, 2024 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 28, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants