Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gas fee edit from swaps #12455

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 26, 2024

Description

Prevent crash when editing gas fee during swap.

Related issues

Fixes: #12387 #12457

Manual testing steps

See issue.

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-27.at.00.01.05.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 26, 2024 23:59
@matthewwalsh0 matthewwalsh0 added team-confirmations Push issues to confirmations team Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 26, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3942be0
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a20cfa2b-8c1d-4657-a33f-0079b42c2f7f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 27, 2024
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 51798b8 Nov 27, 2024
62 of 63 checks passed
@matthewwalsh0 matthewwalsh0 deleted the fix/12387-swaps-horizontal-selector-crash branch November 27, 2024 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
5 participants