Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create ci workflow for multichain flow #12425

Merged
merged 40 commits into from
Nov 28, 2024

Conversation

cortisiko
Copy link
Member

@cortisiko cortisiko commented Nov 26, 2024

Description

This PR addresses the new flows introduced with the updated network chain permissions functionality. The goal is to ensure comprehensive automated test coverage for these changes, reducing the risk of bugs found later in the development process.

Key things to note here:
breakdown of the CI workflows:

  • Smoke Pipeline: This pipeline runs all E2E tests with an enabled multichain flag. This ensures that engineers actively validate the new MC flows as part of their workflow. By default, the smoke pipeline runs on pull requests, allowing us to catch any issues with the MC flow before changes are merged into the main branch. We plan to make the smoke E2E pipeline a required step before merging PRs soon.

  • Regression Pipeline: This pipeline runs E2E tests with the multichain flag disabled. It ensures that existing functionality remains stable without the MC changes. The regression pipeline is scheduled to run every four hours against the main branch, providing frequent and consistent validation of the baseline functionality.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.82%. Comparing base (22a4989) to head (c9cecd1).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12425      +/-   ##
==========================================
+ Coverage   56.41%   56.82%   +0.41%     
==========================================
  Files        1797     1813      +16     
  Lines       40586    40862     +276     
  Branches     5097     5164      +67     
==========================================
+ Hits        22896    23221     +325     
+ Misses      16134    16054      -80     
- Partials     1556     1587      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortisiko cortisiko added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a2b3200
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c401665f-0d02-43cb-ad5f-06c6df3b3795

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@EtherWizard33 EtherWizard33 self-requested a review November 28, 2024 17:24
EtherWizard33
EtherWizard33 previously approved these changes Nov 28, 2024
tommasini
tommasini previously approved these changes Nov 28, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Nov 28, 2024
@cortisiko cortisiko removed this pull request from the merge queue due to a manual request Nov 28, 2024
@cortisiko cortisiko dismissed stale reviews from tommasini and EtherWizard33 via 76ffa81 November 28, 2024 17:57
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6c51ab1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/930bc755-546a-4a06-a93f-43d5a11cedba

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cortisiko cortisiko enabled auto-merge November 28, 2024 18:36
@EtherWizard33 EtherWizard33 self-requested a review November 28, 2024 18:46
@cortisiko cortisiko added this pull request to the merge queue Nov 28, 2024
@EtherWizard33 EtherWizard33 removed this pull request from the merge queue due to a manual request Nov 28, 2024
@EtherWizard33 EtherWizard33 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit d71de20 Nov 28, 2024
43 of 45 checks passed
@EtherWizard33 EtherWizard33 deleted the test-multichain-e2e-ci-workflow branch November 28, 2024 19:16
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-wallet-ux
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants