Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(3598): non permitted chain flow small improvements #12420

Merged
merged 7 commits into from
Nov 26, 2024
Merged

feat(3598): non permitted chain flow small improvements #12420

merged 7 commits into from
Nov 26, 2024
+19 −21

Conversation

EtherWizard33
Copy link
Contributor

@EtherWizard33 EtherWizard33 commented Nov 25, 2024 •
edited
Loading

Description

  • the current active network should also be available from the checkbox list.
  • also added logging that was missing.

Related issues

Fixes:

Manual testing steps

  1. Go to main screen and switch to a network that is not permitted for that connected dapp, in the example below pancake swap.
  2. Go to the dapp, ignore the first opportunity to grant permission for the current network and go to the checkbox list, then grant permission to the current active network.
  3. Now that permission is granted pick that network, the bottom sheet closes.

Screenshots/Recordings

Before After
Screenshot 2024-04-18 at 3 56 43 PM Screenshot 2024-04-18s at 3 56 43 PM

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux labels Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6191b8b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1742ffef-64df-463c-a91e-034049381379

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 25, 2024
@EtherWizard33 EtherWizard33 marked this pull request as ready for review November 25, 2024 21:55
@EtherWizard33 EtherWizard33 requested review from a team as code owners November 25, 2024 21:55
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. and removed Run Smoke E2E Triggers smoke e2e on Bitrise No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 26, 2024
@EtherWizard33 EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0364026
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b96f314-23a7-4747-9efb-b4ff6e807389

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

vinnyhoward
vinnyhoward approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@EtherWizard33 EtherWizard33 added this pull request to the merge queue Nov 26, 2024
@EtherWizard33 EtherWizard33 removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 26, 2024
@EtherWizard33 EtherWizard33 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 45e6d63
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eae92099-4a0c-4c83-ba33-25c296eae6c1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Merged via the queue into main with commit ece0220 Nov 26, 2024
42 of 43 checks passed
@EtherWizard33 EtherWizard33 deleted the feat-3598-non-permitted-chain-flow-small-improvements branch November 26, 2024 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

Assignees
No one assigned
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EtherWizard33 @vinnyhoward @tommasini @metamaskbot