Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Chore/update accounts controller messenger code owner #12416

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Nov 25, 2024

Description

This PR moves the AccountsController restricted messenger back into the Engine to ensure that platform team is notified of any changes. It also ensures that the AccountsController throws if initialization fails, persisting the behavior of how it was before.

Related issues

Fixes: Related #12366

Manual testing steps

No changes for app behavior. Operate as usual. Ensure that e2e passes

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners November 25, 2024 19:15
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 25, 2024
@Cal-L Cal-L added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4943178
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/61bc1fdf-3418-448e-8f36-2cc7c07957e8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Cal-L
Copy link
Contributor Author

Cal-L commented Nov 25, 2024

Failure on E2E is on main and not related to this PR

@Cal-L Cal-L added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit ab63da1 Nov 25, 2024
39 of 40 checks passed
@Cal-L Cal-L deleted the chore/update-accounts-controller-messenger-code-owner branch November 25, 2024 20:11
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants