Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit input digits to 12 in useInputHandler #12398

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Nov 22, 2024

Description

This pull request adds a maximum digit limit of 12 in the useInputHandler function. It ensures that the input value is restricted to 12 digits and prevents any further input beyond that limit. This enhancement improves the user experience by enforcing a consistent and manageable input length.

Related issues

Fixes: STAKE-877

Manual testing steps

  1. Go to Stake Input or Unstake Input page
  2. Try to enter more than 12 digits using keypad on the screen
  3. You should not be able to enter more than 12 digits

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 22, 2024
@amitabh94 amitabh94 marked this pull request as ready for review November 22, 2024 17:28
@amitabh94 amitabh94 requested a review from a team as a code owner November 22, 2024 17:28
@amitabh94 amitabh94 enabled auto-merge November 22, 2024 17:28
@amitabh94 amitabh94 force-pushed the STAKE-877-restrict-digits-input-screen branch from f84294f to b59d33d Compare November 22, 2024 17:29
Copy link
Contributor

github-actions bot commented Nov 22, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b59d33d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59733a6e-a1bd-4fa2-be6c-64f2d105f16f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitabh94 amitabh94 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 7bb23c9 Nov 22, 2024
37 checks passed
@amitabh94 amitabh94 deleted the STAKE-877-restrict-digits-input-screen branch November 22, 2024 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants