-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ramp): enable buy button in asset overview #12396
Conversation
Bitrise🔄🔄🔄 Commit hash: be7c818 Note
|
Bitrise✅✅✅ Commit hash: 2de74a0 Note
|
Bitrise✅✅✅ Commit hash: 1cbd3bf Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. However, it seems like we're missing some UX here since we're not notifying the user that the token is not available for buying in their region. Defaulting to the default token can also easily be interpreted as a bug in a sense that the wrong token may have been selected. Is the fallback condition a result of not having a region selected in the first place?
Yes I agree, we can improve this by adding a message to let the user the token is not available.
No, the fallback happens when the token is not available. In the case has not selected region and payment method and they do it in this flow, the token will be selected if it was available. |
Quality Gate passedIssues Measures |
Description
This PR adds the buy button to the Token (AssetOverview) page, using the Ramp Intent parameters to optimistically open the Buy flow with the token selected. The Buy button will show if the network is supported.
Happy Path / Optimistic case description:
Given:
Then:
Other cases:
Related issues
Fixes: #12396
Manual testing steps
Screenshots/Recordings
Before
No Buy button
no_buy_button.mp4
After
Happy Path
buy_button_asset_overview.mp4
Token unavailable (default token is selected)
other_cases.mp4
Pre-merge author checklist
Pre-merge reviewer checklist