Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crashing after send or swap #12367

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: app crashing after send or swap #12367

merged 1 commit into from
Nov 21, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Nov 21, 2024

Description

Fix bug app crash after send / swap.

Related issues

Fixes: #12364

Manual testing steps

  1. Go to Advance setting and turn STX on
  2. Swap any pair of token or send money
  3. Notice the app will crash

Screenshots/Recordings

Screen.Recording.2024-11-21.at.4.28.03.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team labels Nov 21, 2024
@jpuri jpuri requested review from a team as code owners November 21, 2024 10:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 55a890e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fb20651c-f09a-46da-b000-9f202c255230

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jpuri jpuri changed the title Fix: app crashing after send or swap fix: app crashing after send or swap Nov 21, 2024
@jpuri jpuri enabled auto-merge November 21, 2024 11:03
@jpuri jpuri added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 75fa93a Nov 21, 2024
47 of 49 checks passed
@jpuri jpuri deleted the confirm_bug_fix branch November 21, 2024 11:28
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: With STX on the app will crash when initiating a swap or send
5 participants