Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unit tests for tags approval controller undefined #12362

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

tommasini
Copy link
Contributor

Description

Add unit tests for approval controller be undefined and pendingApprovals be undefined as well

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 20, 2024
@tommasini tommasini requested a review from a team as a code owner November 20, 2024 20:25
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (22a4989) to head (fb06630).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12362      +/-   ##
==========================================
- Coverage   56.41%   56.39%   -0.03%     
==========================================
  Files        1797     1804       +7     
  Lines       40586    40650      +64     
  Branches     5097     5117      +20     
==========================================
+ Hits        22896    22923      +27     
- Misses      16134    16156      +22     
- Partials     1556     1571      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 0fe5b98
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c9cb18a7-bcd9-46a0-9aa4-e44565a115be

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit f35eda8 Nov 21, 2024
43 checks passed
@tommasini tommasini deleted the chore/unit-test-approval-controller-tags branch November 21, 2024 01:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 21, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants