Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add missing confirmation unit tests #12355

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

OGPoyraz
Copy link
Member

Description

This PR purely adds missing confirmation unit tests and improve snapshot testing.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3584

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@OGPoyraz OGPoyraz added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 20, 2024
@OGPoyraz OGPoyraz requested review from a team as code owners November 20, 2024 14:31
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Nov 20, 2024
@OGPoyraz OGPoyraz enabled auto-merge November 21, 2024 10:52
@OGPoyraz OGPoyraz added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 628caa1 Nov 22, 2024
37 checks passed
@OGPoyraz OGPoyraz deleted the chore/improve-confirmation-unit-tests-1 branch November 22, 2024 09:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants