Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ramp): remove anonymous events #12351

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Conversation

wachunei
Copy link
Member

Description

This PR removes all of the anonymous events from the Ramp analytics setup

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/RAMPS-2034

Manual testing steps

  1. Go to Buy or Sell flow
  2. Confirm the events are being tracked

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 3498405
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d96c1576-2050-4675-8911-b127134c21e4

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c5bdb9f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3290b16d-b1c4-4c5a-a0ae-0d599b2256c2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei marked this pull request as ready for review November 20, 2024 15:00
@wachunei wachunei requested review from a team as code owners November 20, 2024 15:00
AxelGes
AxelGes previously approved these changes Nov 21, 2024
@wachunei wachunei force-pushed the refactor/ramp-remove-anon-events branch from 4a6b950 to cc00502 Compare November 21, 2024 15:37
@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 87707b9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5a97da60-3122-41fc-bcd6-197acfec7e8e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@wachunei wachunei removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-ramp-qa Tickets that need feature QA on the ramps flows labels Nov 21, 2024
@wachunei wachunei added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit fec0c4e Nov 21, 2024
49 checks passed
@wachunei wachunei deleted the refactor/ramp-remove-anon-events branch November 21, 2024 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants