chore: Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0 #12339

owencraston · 2024-11-19T21:42:43Z

Description

This PR updates the accounts controller to the latest version of 19. This updates requires a peer dependancy bump of the keyring controller to version 18.0.0

See accounts controller changelog.
See keyring controller changelog.
- version 18 of the keyring controller removes the addNewAccountWithoutUpdate which is used once in the mobile repo. In order to merge this PR we will need to wait for @mikesposito's PR to merge. This PR removes the need for addNewAccountWithoutUpdate and improves performance/reliability.

Related issues

Fixes: #12302
Fixes: #12304

Unblocked by: #11409

Manual testing steps

Account creation

open app
press create wallet
go through the onboarding flow
once onboarding is complete, you should be on the wallet view and see a single account
open the account selector list and add a new account'
this should work without issues
change the name of your new account
force close the app and reopen, the previously selected account should be the same and the custom name should be preserved.

Account importing

assuming you have created a wallet wth the above steps....
open the account selector list and click add account or hardware wallet and then click import account
paste a private key in this text field and then import
the account should be imported, selected and have the label "imported"
force closing the app and re opening it should preserve the same state of accounts

Hardware wallets

assuming you have created a wallet wth the above steps....
open the account selector list and click add account or hardware wallet and then click Add hardware wallet
select your hardware wallet of choice (ledger or qr based)
follow the instructions to add a hardware wallet
the steps should work and you should have successfully added a hardware account
the hardware account should have the correct labels (either Qr hardware or ledger)
force closing the app and reopening should preserve the same accounts state.

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-27.at.12.41.48.PM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-19T21:42:55Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-11-19T21:43:56Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/accounts-controller@19.0.0	None	`0`	267 kB	metamaskbot
npm/@metamask/approval-controller@7.1.1	None	`0`	221 kB	metamaskbot
npm/@metamask/eth-snap-keyring@4.4.0	Transitive: network	`+3`	2.86 MB
npm/@metamask/json-rpc-engine@10.0.1	None	`0`	178 kB	metamaskbot
npm/@metamask/json-rpc-middleware-stream@8.0.5	None	`0`	49.9 kB	metamaskbot
npm/@metamask/keyring-controller@18.0.0	Transitive: environment	`+2`	630 kB	danfinlay, gudahtt, kumavis, ...7 more
npm/@metamask/permission-controller@11.0.3	None	`0`	910 kB	metamaskbot
npm/@metamask/providers@18.1.1	None	`0`	439 kB	metamaskbot
npm/@metamask/snaps-controllers@9.14.0	None	`0`	1.65 MB	metamaskbot
npm/@metamask/snaps-registry@3.2.2	None	`0`	54.6 kB	danfinlay, gudahtt, kumavis, ...7 more
npm/@metamask/snaps-rpc-methods@11.6.0	None	`0`	1.25 MB	metamaskbot

🚮 Removed packages: npm/@metamask/accounts-controller@18.2.1, npm/@metamask/approval-controller@7.1.0, npm/@metamask/eth-snap-keyring@4.3.6, npm/@metamask/json-rpc-middleware-stream@8.0.2, npm/@metamask/permission-controller@11.0.0, npm/@metamask/snaps-controllers@9.11.0, npm/@metamask/snaps-registry@3.2.1, npm/@metamask/snaps-rpc-methods@11.4.0, npm/@metamask/snaps-sdk@6.9.0, npm/@metamask/snaps-utils@8.4.0

View full report↗︎

github-actions · 2024-11-19T23:28:07Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 24bfc6c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f8893ed8-ce7f-4e18-9e35-560f827dc7c3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-11-27T18:00:50Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d035bcb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/eb88c468-4683-4d00-a460-7f9a8ecf08d7

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-11-27T19:21:05Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 38174e5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/247e5e0f-8848-441c-8458-0c6f5e35ddd0

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions · 2024-11-27T20:45:52Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: da504a5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ec58dba2-5b49-4bf7-b09e-eab458cff824

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2024-11-27T21:29:10Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d53f7f5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2818c0d9-b327-4e45-8757-223b3c0dd579

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-11-27T21:30:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L

Could you also sync with @tommasini on these changes since he's working on a performance optimization, which includes a keyringcontroller patch

yarn.lock

app/core/Engine/Engine.ts

tommasini

LGTM!

Yeah, the Keyring Controller patch will need to be applied to this version as well!

owencraston · 2024-11-27T23:36:45Z

confirmed that the dapp interactions seem to be working as expected.

metamaskbot added the team-accounts label Nov 19, 2024

owencraston mentioned this pull request Nov 19, 2024

refactor: use withKeyring to batch account restore operation #11409

Merged

7 tasks

owencraston force-pushed the chore/accounts-controller-bump branch from f347b89 to 24bfc6c Compare November 19, 2024 21:53

owencraston added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 19, 2024

tommasini mentioned this pull request Nov 25, 2024

fix: Decrease unlock time #12421

Closed

7 tasks

bump accounts and keyring controller

d035bcb

owencraston force-pushed the chore/accounts-controller-bump branch from 24bfc6c to d035bcb Compare November 27, 2024 17:59

owencraston marked this pull request as ready for review November 27, 2024 18:00

owencraston requested review from a team as code owners November 27, 2024 18:00

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 27, 2024

owencraston added 2 commits November 27, 2024 10:06

dedupe

19ab867

fix yarn.lock

38174e5

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 27, 2024

dedupe

da504a5

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 27, 2024

resolve duplicate utils deps

d53f7f5

owencraston changed the title ~~chore/ Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0~~ chore: Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0 Nov 27, 2024

owencraston added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 27, 2024

This was referenced Nov 27, 2024

chore: bump @metamask/preferences-controller to ^14.0.0 #12472

Merged

chore: bump @metamask/signature-controller to ^22.0.0 #12474

Merged

Cal-L reviewed Nov 27, 2024

View reviewed changes

yarn.lock Show resolved Hide resolved

tommasini reviewed Nov 27, 2024

View reviewed changes

app/core/Engine/Engine.ts Show resolved Hide resolved

tommasini approved these changes Nov 27, 2024

View reviewed changes

owencraston added this pull request to the merge queue Nov 27, 2024

Merged via the queue into main with commit 9059cc0 Nov 27, 2024
46 of 47 checks passed

owencraston deleted the chore/accounts-controller-bump branch November 27, 2024 23:51

github-actions bot locked and limited conversation to collaborators Nov 27, 2024

metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0 #12339

chore: Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0 #12339

owencraston commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 19, 2024

socket-security bot commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 19, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Nov 27, 2024

Cal-L left a comment

tommasini left a comment •

edited

Loading

owencraston commented Nov 27, 2024

chore: Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0 #12339

chore: Update accounts-controller @v19.0.0 and keyring-controller @v18.0.0 #12339

Conversation

owencraston commented Nov 19, 2024 • edited Loading

Description

Related issues

Manual testing steps

Account creation

Account importing

Hardware wallets

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 19, 2024

socket-security bot commented Nov 19, 2024 • edited Loading

github-actions bot commented Nov 19, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Nov 27, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Nov 27, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Nov 27, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Nov 27, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Nov 27, 2024

Quality Gate passed

Cal-L left a comment

Choose a reason for hiding this comment

tommasini left a comment • edited Loading

Choose a reason for hiding this comment

owencraston commented Nov 27, 2024

owencraston commented Nov 19, 2024 •

edited

Loading

socket-security bot commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 19, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 27, 2024 •

edited by metamaskbot

Loading

tommasini left a comment •

edited

Loading