Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating filter icon #12334

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: updating filter icon #12334

merged 1 commit into from
Nov 22, 2024

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Nov 19, 2024

Description

This pull request updates the filter icon's stroke thickness to align with the Figma design and other icons in the MetaMask design system. The current filter icon's stroke is thinner than intended, causing inconsistency with the overall visual hierarchy of the design system. Adjusting the stroke ensures better alignment and uniformity across the UI elements.

Related issues

Fixes: #12333

Manual testing steps

  1. Navigate to a screen in the MetaMask extension where the filter icon is displayed.
  2. Verify the updated filter icon's stroke thickness matches the Figma design specifications.
  3. Compare the filter icon with other icons in the design system to confirm visual consistency.

Screenshots/Recordings

Screenshot 2024-11-19 at 10 36 30 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 19, 2024 18:36
@georgewrmarshall georgewrmarshall self-assigned this Nov 19, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added team-design-system All issues relating to design system in Mobile No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 19, 2024
@brianacnguyen brianacnguyen added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit d8af0a6 Nov 22, 2024
37 checks passed
@brianacnguyen brianacnguyen deleted the fix/filter-icon branch November 22, 2024 03:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-design-system All issues relating to design system in Mobile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix filter icon
3 participants