Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not show staked eth balance when balance is zero on homepage or asset detail #12332

Conversation

nickewansmith
Copy link
Contributor

@nickewansmith nickewansmith commented Nov 19, 2024

Description

  1. What is the reason for the change?

We have decided that we should hide the staked ethereum balance if it is 0 on mobile.

  1. What is the improvement/solution?

Ensure that the staked ethereum asset does not show when the balance is zero on the homepage and on the ETH asset detail page.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/STAKE-874

Manual testing steps

  1. On this branch
  2. If you have a zero Staked ETH balance, you should see no Staked Ethereum asset on the homepage or on the ETH asset detail page after clicking the ETH asset on homepage.
  3. If you do have Staked ETH already, then you should see that ETH on the homepage and on the ETH asset detail page as well. Unstake Max ETH and wait for transaction to confirm. When you check homepage and ETH asset detail page, there should be no Staked Ethereum listed as balance is now 0.

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-11-19.at.11.32.38.mp4

After

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2024-11-19.at.11.42.12.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…-when-user-has-no-positions-or-never-staked-before
@nickewansmith nickewansmith added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 19, 2024
@nickewansmith nickewansmith marked this pull request as ready for review November 19, 2024 17:49
@nickewansmith nickewansmith requested review from a team as code owners November 19, 2024 17:49
Copy link
Contributor

github-actions bot commented Nov 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 428d42f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a8bdf093-4ff7-4805-932c-65658f70a955

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickewansmith nickewansmith added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit fb69962 Nov 19, 2024
42 checks passed
@nickewansmith nickewansmith deleted the STAKE-874-hide-0-staked-balances-on-homepage-when-user-has-no-positions-or-never-staked-before branch November 19, 2024 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 19, 2024
@smilingkylan smilingkylan added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants