Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide rpc url selector for networks with one rpc #12319

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 17, 2024

Description

This pull request aims to enhance the user experience by conditionally hiding the RPC selector URL when the network has only one available option. By removing unnecessary UI elements in such cases, this update ensures a cleaner and more intuitive interface.

Related issues

Fixes:

Manual testing steps

  1. Go to Network selector
  2. Check for network with single RPC
  3. You should not see the rpc selector

Screenshots/Recordings

Before

Screen.Recording.2024-11-17.at.09.15.38.mov

After

Screen.Recording.2024-11-17.at.09.06.19.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Nov 17, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 17, 2024
@salimtb salimtb force-pushed the salim/fix-rpc-selector-single-url branch from 457c0d6 to 16dd0db Compare November 17, 2024 08:39
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 17, 2024
Copy link
Contributor

github-actions bot commented Nov 17, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 16dd0db
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/15dcf7c3-0416-42ad-a2ae-e6338541457f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MetaMask MetaMask deleted a comment from github-actions bot Nov 17, 2024
@salimtb

This comment has been minimized.

@salimtb salimtb marked this pull request as ready for review November 17, 2024 08:57
@salimtb salimtb requested a review from a team as a code owner November 17, 2024 08:57
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salimtb salimtb added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 1ffb17e Nov 22, 2024
37 checks passed
@salimtb salimtb deleted the salim/fix-rpc-selector-single-url branch November 22, 2024 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants