-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e: ensure Decrypt button is displayed #12315
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: bd283ed Note
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12315 +/- ##
=======================================
Coverage 56.41% 56.41%
=======================================
Files 1797 1798 +1
Lines 40586 40615 +29
Branches 5097 5100 +3
=======================================
+ Hits 22896 22913 +17
- Misses 16134 16140 +6
- Partials 1556 1562 +6 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: c89f696 Note
|
Description
Fix a flaky test that seems to be failing to tap Decrypt button by adding another scrollToDecrypt().
Related issues
Fixes: https://github.com/MetaMask/mobile-planning/issues/2044
Manual testing steps
yarn test:e2e:android:debug:run ./e2e/specs/accounts/aes/encryption-with-password.spec.js
on local system and test should passrun_tag_smoke_accounts_android
should pass all test on pipelinesScreenshots/Recordings
Before
Flaky test run: https://app.bitrise.io/build/5b4ae852-dbbc-4014-91f9-b439c01e4243?tab=tests
After
See E2E test run
Pre-merge author checklist
Pre-merge reviewer checklist