Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e: ensure Decrypt button is displayed #12315

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 16, 2024

Description

Fix a flaky test that seems to be failing to tap Decrypt button by adding another scrollToDecrypt().

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2044

Manual testing steps

  1. run yarn test:e2e:android:debug:run ./e2e/specs/accounts/aes/encryption-with-password.spec.js on local system and test should pass
  2. bitrise workflow run_tag_smoke_accounts_android should pass all test on pipelines

Screenshots/Recordings

Before

Flaky test run: https://app.bitrise.io/build/5b4ae852-dbbc-4014-91f9-b439c01e4243?tab=tests

After

See E2E test run

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 16, 2024
Copy link
Contributor

github-actions bot commented Nov 16, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: bd283ed
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9192de96-1fbb-4e77-aae2-e22ab6c5b506

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.41%. Comparing base (22a4989) to head (c89f696).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12315   +/-   ##
=======================================
  Coverage   56.41%   56.41%           
=======================================
  Files        1797     1798    +1     
  Lines       40586    40615   +29     
  Branches     5097     5100    +3     
=======================================
+ Hits        22896    22913   +17     
- Misses      16134    16140    +6     
- Partials     1556     1562    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 19, 2024 16:56
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 19, 2024 16:56
@chrisleewilcox chrisleewilcox changed the title fix: e2e: ensure decrypt button is displayed fix: e2e: ensure Decrypt button is displayed Nov 19, 2024
@chrisleewilcox chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 19, 2024
Copy link
Contributor

github-actions bot commented Nov 19, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c89f696
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7ab4e001-f9b9-4ce7-bf37-10d47446a243

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chrisleewilcox chrisleewilcox added this pull request to the merge queue Nov 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2024
@chrisleewilcox chrisleewilcox added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 3b269ce Nov 19, 2024
55 checks passed
@chrisleewilcox chrisleewilcox deleted the test/add-scroll-decrypt branch November 19, 2024 22:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants