Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove run all tests section #12313

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 15, 2024

Description

Run all test locally with a single command is not recommended as running all tests are not ran in the same manner on CI. This will also prevent some confusion with new contributors running all test the first time which will take a long time. Removing the run all test section will make it more clear to new contributors to run a specific test or a suite of tests as currently documented and is more align with how we run test in CI.

Related issues

Fixes: team members running into issue attempting to run e2e test on their local system for the first time.

Manual testing steps

  1. document running a single test
  2. document running a suite of tests
  3. no document for running all test with a single command

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Run all test locally is not recommended as test are not ran in the same manner on CI.  This will also prevent some confusion with contributors running the test the first time and having all test run which will take a long time.  Removing the run all test section will make it more clear to new contributors to run a specific test or a suite of tests as currently documented.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 22, 2024 15:08
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 22, 2024 15:08
@chrisleewilcox chrisleewilcox self-assigned this Nov 22, 2024
@chrisleewilcox chrisleewilcox added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit ad8ffb1 Nov 25, 2024
47 of 49 checks passed
@chrisleewilcox chrisleewilcox deleted the remove-run-all-test-section branch November 25, 2024 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants