Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: conditionally display stake/earn text based on pooled staking feature flag #12261

Merged
merged 4 commits into from
Nov 12, 2024
Merged

feat: conditionally display stake/earn text based on pooled staking feature flag #12261

merged 4 commits into from
Nov 12, 2024
+3 −1

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Nov 12, 2024 •
edited
Loading

Description

Updates StakeButton component to show different text based on whether pooled
staking is enabled. Shows "earn" when pooled staking is active, and "stake"
when using traditional staking.

Manual testing steps

  1. Set export MM_POOLED_STAKING_UI_ENABLED=true in your local .js.env file
  2. Go to Homepage and you should see 'Earn' CTA
  3. Disable the flag in .js.env and then go to homepage , and now you should see 'Stake' CTA

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@amitabh94
feat: conditionally display stake/earn text based on pooled staking f…
154ee95 
…eature flag

Updates StakeButton component to show different text based on whether pooled
staking is enabled. Shows "earn" when pooled staking is active, and "stake"
when using traditional staking.
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 marked this pull request as ready for review November 12, 2024 15:26
@amitabh94 amitabh94 requested a review from a team as a code owner November 12, 2024 15:26
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 12, 2024
@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 12, 2024
@amitabh94 amitabh94 enabled auto-merge November 12, 2024 15:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c7993ae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/651f0f58-ef3a-4f40-b04f-b370919cb210

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 12, 2024
nickewansmith
nickewansmith previously approved these changes Nov 12, 2024
View reviewed changes
@amitabh94 amitabh94 added this pull request to the merge queue Nov 12, 2024
@amitabh94 amitabh94 removed this pull request from the merge queue due to a manual request Nov 12, 2024
@amitabh94 amitabh94 removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 12, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 12, 2024
@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 07f0901
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dffcc36a-99be-449d-8369-7f6ac83ad0bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@amitabh94 amitabh94 enabled auto-merge November 12, 2024 16:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@amitabh94 amitabh94 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 9ccffcf Nov 12, 2024
36 of 37 checks passed
@amitabh94 amitabh94 deleted the feat/update-stake-cta branch November 12, 2024 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nickewansmith nickewansmith nickewansmith approved these changes

Assignees
No one assigned
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitabh94 @nickewansmith @gauthierpetetin @metamaskbot