Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix displayed selected rpc for linea #12255

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 9, 2024

Description

the displayed selected rpc for linea is not the correct one

Related issues

Fixes: #12252

Manual testing steps

  1. Go Network selector
  2. add another rpc for linea
  3. check the selected rpc on the network selector view

Screenshots/Recordings

Before

After

Screen.Recording.2024-11-09.at.13.37.00.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb self-assigned this Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb force-pushed the salim/fix-selected-rpc-linea branch from 29d8dbd to 5dc9fbd Compare November 9, 2024 12:36
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 5dc9fbd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c21f328d-9afe-4ba5-ae28-06abd701bf7e

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.32%. Comparing base (9f29292) to head (5dc9fbd).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12255      +/-   ##
==========================================
+ Coverage   55.78%   56.32%   +0.53%     
==========================================
  Files        1786     1790       +4     
  Lines       40362    40469     +107     
  Branches     5054     5083      +29     
==========================================
+ Hits        22516    22794     +278     
+ Misses      16297    16124     -173     
- Partials     1549     1551       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salimtb salimtb force-pushed the salim/fix-selected-rpc-linea branch from 5dc9fbd to 85f7331 Compare November 9, 2024 12:47
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 85f7331
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1c7c8394-6739-4b1f-8b08-1eee8a6e5c45

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb marked this pull request as ready for review November 9, 2024 12:52
@salimtb salimtb requested a review from a team as a code owner November 9, 2024 12:52
@salimtb
Copy link
Contributor Author

salimtb commented Nov 9, 2024

@salimtb salimtb added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 0d77c6e Nov 12, 2024
37 checks passed
@salimtb salimtb deleted the salim/fix-selected-rpc-linea branch November 12, 2024 11:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with the switching the Linea Mainnet to an alternative RPC URL
5 participants