Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add migration to fix NotificationServicesController bug #12236

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

smilingkylan
Copy link
Contributor

… on this branch

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 7, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 984d81c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/971e1f1d-efc8-4c97-b098-b19687f6f1e6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman marked this pull request as ready for review November 7, 2024 22:47
@sethkfman sethkfman requested a review from a team as a code owner November 7, 2024 22:47
@smilingkylan smilingkylan changed the title [fix] Add migration to fix NotificationServicesController bug fix: Add migration to fix NotificationServicesController bug Nov 7, 2024
Copy link

sonarqubecloud bot commented Nov 7, 2024

@smilingkylan smilingkylan merged commit 409c14f into release/7.34.1 Nov 7, 2024
39 of 40 checks passed
@smilingkylan smilingkylan deleted the cherry-pick-8d65907 branch November 7, 2024 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants