Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e re-enable notifications android workflow #12232

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 7, 2024

Description

Increase test coverage by re-enable run_tag_smoke_notifications_android CI workflow.

  • Re-enable workflow
  • fix flaky tests
  • Adjust test to use hooks

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2033

Manual testing steps

  • Run smoke tests on bitrise
  • All test pass

Screenshots/Recordings

Before

Disabled

After

See e2e results

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added E2E Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4af9fb5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d80ca594-c608-4411-9dee-8d99498f0681

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@chrisleewilcox chrisleewilcox added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cc6dc22
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/691a78aa-72e8-445d-af33-2a5c96750c96

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chrisleewilcox chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c083e8e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af65a072-4c8f-4064-a500-524099537a94

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Nov 7, 2024

@chrisleewilcox chrisleewilcox requested a review from a team November 7, 2024 22:10
@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 7, 2024 22:12
@chrisleewilcox chrisleewilcox requested review from a team as code owners November 7, 2024 22:12
@chrisleewilcox chrisleewilcox self-assigned this Nov 7, 2024
@chrisleewilcox chrisleewilcox changed the title fix: e2e re enable notifications android workflow fix: e2e re-enable notifications android workflow Nov 7, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 2af2f67 Nov 8, 2024
62 checks passed
@chrisleewilcox chrisleewilcox deleted the tests/re-enable-notifications-android-workflow branch November 8, 2024 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants