Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added ScrollView to stake confirmation review screen #12231

Conversation

Matt561
Copy link
Contributor

@Matt561 Matt561 commented Nov 7, 2024

Description

The Staking review screen was previously being cut off on device with a shorter screen height. This made the button on the page inaccessible to the user.

Related issues

Jira Ticket: STAKE-865: Staking confirmation view cut off on smaller devices

Manual testing steps

Prerequisites:

  • Use a smaller device in your simulator (e.g. iPhone SE 3rd generation)
  • Ensure you have ETH in your wallet in order to go through the staking flow.
  1. Set export MM_POOLED_STAKING_UI_ENABLED=true in your local .js.env file
  2. From the asset list page, click Ethereum
  3. Click on "Stake" or "Stake More" buttons to begin staking flow
  4. Enter any valid amount to stake and click "Review"
  5. In the stake confirmation screen you should be able to scroll down. The overflowing content is no longer inaccessible.

Screenshots/Recordings

Before

image

After

stake-865-staking-confirmation-view-cutt-off-on-smaller-devices-after.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Matt561 Matt561 requested a review from a team as a code owner November 7, 2024 18:42
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-identity labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 351ac58
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/68623b78-9a9b-4dcc-8757-23d3dad1c839

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Matt561 Matt561 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b7b65ac
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/de053c21-2644-4d28-ab89-77fe1409ad54

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Nov 7, 2024

@Matt561 Matt561 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 3cd5dd6 Nov 7, 2024
43 checks passed
@Matt561 Matt561 deleted the fix/STAKE-865-staking-confirmation-view-cut-off-on-smaller-devices branch November 7, 2024 22:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants