-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added ScrollView to stake confirmation review screen #12231
fix: added ScrollView to stake confirmation review screen #12231
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise❌❌❌ Commit hash: 351ac58 Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…off-on-smaller-devices
Bitrise✅✅✅ Commit hash: b7b65ac Note
|
Quality Gate passedIssues Measures |
Description
The Staking review screen was previously being cut off on device with a shorter screen height. This made the button on the page inaccessible to the user.
Related issues
Jira Ticket: STAKE-865: Staking confirmation view cut off on smaller devices
Manual testing steps
Prerequisites:
export MM_POOLED_STAKING_UI_ENABLED=true
in your local.js.env
fileScreenshots/Recordings
Before
After
stake-865-staking-confirmation-view-cutt-off-on-smaller-devices-after.mov
Pre-merge author checklist
Pre-merge reviewer checklist