Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set default selectedNetworkClientId to 'mainnet' if no matching with entry on network list #12227

Merged
merged 6 commits into from
Dec 19, 2024
Merged

fix: set default selectedNetworkClientId to 'mainnet' if no matching with entry on network list #12227

merged 6 commits into from
Dec 19, 2024
+342 −0

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 7, 2024 •
edited
Loading

Description

This PR implements a fix for Migration 60 to handle cases where selectedNetworkClientId does not match any entry within networkConfigurationsByChainId. If no corresponding networkClientId is found, the migration will now set selectedNetworkClientId to 'mainnet' by default.

Related issues

Fixes: #11657

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb changed the title fix: set default selectedNetworkClientId to 'mainnet' if no matching … fix: set default selectedNetworkClientId to 'mainnet' if no matching with entry on network list Nov 7, 2024
@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 217b7c7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1ac32bd6-f3c1-425a-a38c-a0cfbbe6e5cc

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb marked this pull request as ready for review November 7, 2024 09:53
@salimtb salimtb requested a review from a team as a code owner November 7, 2024 09:53
@salimtb salimtb closed this Dec 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
@salimtb salimtb reopened this Dec 4, 2024
@salimtb salimtb requested a review from a team as a code owner December 4, 2024 16:56
@salimtb
fix: set default selectedNetworkClientId to 'mainnet' if no matching …
7b7d732 
…entry exists in networkConfigurationsByChainId
@salimtb salimtb force-pushed the fix/migration-60-selectedNetworkClientId-default branch from 217b7c7 to 7b7d732 Compare December 4, 2024 17:10
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7b7d732
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d68ec5c4-ae82-44ef-a73c-6e46b500eeba

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions github-actions bot unlocked this conversation Dec 4, 2024
Cal-L
Cal-L reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

app/store/migrations/062.ts Outdated Show resolved Hide resolved
app/store/migrations/062.ts Outdated Show resolved Hide resolved
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 70b0603
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/84ba0dad-cfe4-45ef-98e1-64db16caaf4e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f1868cc
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/881acef6-391a-48b2-9bfc-58d2ad0688f6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
91.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@salimtb salimtb requested a review from Cal-L December 18, 2024 16:46
Cal-L
Cal-L approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@salimtb salimtb added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit dd81987 Dec 19, 2024
40 checks passed
@salimtb salimtb deleted the fix/migration-60-selectedNetworkClientId-default branch December 19, 2024 13:26
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@metamaskbot metamaskbot added the release-7.39.0 Issue or pull request that will be included in release 7.39.0 label Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-7.39.0 Issue or pull request that will be included in release 7.39.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Sentry] Error: Engine does not exist
3 participants
@salimtb @Cal-L @metamaskbot