Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e: use different wallet SRP for non accounts tests #12217

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: e2e: use different wallet SRP for non accounts tests #12217

merged 2 commits into from
Nov 7, 2024
+2 −2

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 6, 2024 •
edited
Loading

Description

There are some performance issues with the existing e2e due to hundreds of accounts added by default which is causing some non-accounts tests to fail

Update flaky test to override default e2e and use a wallet that doesn't have hundreds of accounts added.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

See E2E results

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: da5d00b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/220ed2de-3e06-4830-a28b-9531b24721a8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@chrisleewilcox chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@Cal-L Cal-L added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@chrisleewilcox chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@chrisleewilcox chrisleewilcox added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: de48461
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3028fa60-153b-4c48-b7ac-3166eb8f621f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 7, 2024 02:34
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 7, 2024 02:34
Cal-L
Cal-L approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 6e22952 Nov 7, 2024
45 checks passed
@Cal-L Cal-L deleted the test/use-wallet-srp branch November 7, 2024 05:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
E2E release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisleewilcox @Cal-L @gauthierpetetin @metamaskbot