Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: E2E: quarantine import-wallet-account tests #12197

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 6, 2024

Description

This tests has become flaky and will need to go to quarantine.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2122f77b-77f6-469e-8bd0-c367feb37fca?tab=workflows

After

https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66b628b2-ffbd-4c48-94c2-54199ca71469?tab=workflows

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 282a28c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/66b628b2-ffbd-4c48-94c2-54199ca71469

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@chrisleewilcox chrisleewilcox marked this pull request as ready for review November 6, 2024 05:00
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner November 6, 2024 05:00
@chrisleewilcox chrisleewilcox added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 6, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: db5cd81
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/54206758-9f62-4269-90ad-798882840cc2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Nov 6, 2024

Copy link
Member

@Andepande Andepande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@chrisleewilcox chrisleewilcox added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 1f885dd Nov 6, 2024
42 of 43 checks passed
@chrisleewilcox chrisleewilcox deleted the test/quarantine-import-wallet-account branch November 6, 2024 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants