fix: trackevent enabled is undefined

[NicolasMassart]

Description

Important

The issue is due to the fact that MetaMetrics.trackEvent method has multiple signatures to handle the backward compatibility with old ways to call it.
After discussion (see the change history of this description), we decided to remove backward compatibility and the multiple signature system. We are going to simplify and then fix all the trackEvent calls.
Asside from the changes in MetaMetrics and useMetrics hook (and tests) all the changes should be on the calls of trackEvent.

Current changes in this PR

• removes multiple signature MetaMetrics.trackEvent
• updates MetaMetrics unit tests
• updates useMetrics hook
• updates useMetrics hook unit tests
• deletes now useless legacy compatibility utils
• updates all trackEvent calls
• updates all unit tests that test trackEvent calls

Related issues

Fixes #12117

Manual testing steps

1. navigate the app
2. check trackEvent is called (check app logs)

Screenshots/Recordings

events-1.mov

events-2.mov

Before

N/A

After

N/A

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c34c507
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/379821b0-8f2a-4d77-89aa-e087be7ea3fa

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[NicolasMassart]

Converted to draft as I have issues fixing app/components/Views/Settings/SecuritySettings/Sections/MetaMetricsAndDataCollectionSection/MetaMetricsAndDataCollectionSection.test.tsx

[NicolasMassart]

We decided to go with not fixing but removing the initial cause (that is the backward compatible multi signature trackEvent), and go with a cleanup and update all calls to use new method with event builder.
All changes in this PR will be reverted after this comment.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.35%. Comparing base (b2c9110) to head (962111b).
Report is 22 commits behind head on main.

Files with missing lines	Patch %	Lines
app/components/UI/AccountOverview/index.js	0.00%	2 Missing ⚠️
app/components/UI/AccountRightButton/index.tsx	50.00%	1 Missing ⚠️
app/components/UI/AddCustomCollectible/index.tsx	50.00%	1 Missing ⚠️
app/components/UI/AssetOverview/AssetOverview.tsx	66.66%	1 Missing ⚠️
...onents/UI/LedgerModals/LedgerConfirmationModal.tsx	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12180      +/-   ##
==========================================
+ Coverage   56.31%   56.35%   +0.03%     
==========================================
  Files        1786     1789       +3     
  Lines       40375    40495     +120     
  Branches     5060     5071      +11     
==========================================
+ Hits        22738    22819      +81     
- Misses      16088    16129      +41     
+ Partials     1549     1547       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Matt561]

@NicolasMassart would it be possible to update the recently added withMetaMetrics high order function to make sure these changes don't break our staking events before release? I suspect the lift is small since it's a single function.

I don't mind adding a fix as part of this PR too if you'd rather I do it! Just let me know.

[NicolasMassart]

@NicolasMassart would it be possible to update the recently added withMetaMetrics high order function to make sure these changes don't break our staking events before release? I suspect the lift is small since it's a single function.

I don't mind adding a fix as part of this PR too if you'd rather I do it! Just let me know.

I do not see any reason why this would not work. Your wrapper was already using the new way to call trackEvent.
However, your confidence could be highly improved by simply having a unit test for this withMetaMetrics. So please, write one if you want to make sure your code is not impacted by this or future work.

[sethkfman]

LGTM

[sonarqubecloud]

Quality Gate failed

Failed conditions
41.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud