Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cicd - propagate changes to release pr from scripts #12175

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

jake-perkins
Copy link
Contributor

@jake-perkins jake-perkins commented Nov 4, 2024

Description

Fixes an issue related to a previous commit that caused changes to not be tracked/propagated to the newly minted release PR - 7d4577f

Related issues

Fixes:

Update create-release-pr script such that it creates a new commit with the expected changes housing the version changes

Manual testing steps

No Manual testing, will need to test from CI/CD invocation of manual workflow

Screenshots/Recordings

Before

N/A - CICD change

After

N/A - CICD change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jake-perkins jake-perkins requested a review from a team as a code owner November 4, 2024 22:57
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-dev-ops DevOps team label Nov 4, 2024
@jake-perkins jake-perkins self-assigned this Nov 4, 2024
@jake-perkins jake-perkins added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 4, 2024
Copy link

sonarqubecloud bot commented Nov 5, 2024

Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jake-perkins jake-perkins added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 3802dba Nov 5, 2024
37 checks passed
@jake-perkins jake-perkins deleted the cicd-create-rls-prs branch November 5, 2024 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants