Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove navigation instrumentation #12174

Merged
merged 22 commits into from
Nov 11, 2024
Merged

chore: Remove navigation instrumentation #12174

merged 22 commits into from
Nov 11, 2024
+334 −161

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Nov 4, 2024 •
edited
Loading

Description

This PR removes navigation instrumentation of Sentry configuration.

The reason why we are removing navigation instrumentation is that transaction.durations were not showing accurate values, since if a user backgrounded the app and opened, that time would be added to the transaction.duration, creating issues on our measurements.

Related issues

Fixes: #12165

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini requested a review from a team as a code owner November 4, 2024 22:41
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 4, 2024
MarioAslau
MarioAslau previously approved these changes Nov 5, 2024
View reviewed changes
@tommasini
Removing remaining of sentry react native instrumentation, this way c…
57c9c34 
…onsistently we get in android and IOS the same outputs
@tommasini tommasini dismissed stale reviews from MarioAslau and Cal-L via 57c9c34 November 7, 2024 00:22
@tommasini tommasini requested a review from a team as a code owner November 7, 2024 00:22
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 68d6962
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbd09fdf-33f6-4615-856b-56866e440bc5

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 8, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 8, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b841b3d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3f12d6bc-722d-4dc2-876c-3d8badb5e068

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 26ceb41
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b6cfb28c-9ad7-4075-9d07-a1b12f6e9d17

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
65.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

MarioAslau
MarioAslau approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024
EtherWizard33
EtherWizard33 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@EtherWizard33 EtherWizard33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024
@tommasini tommasini added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 722d4bb Nov 11, 2024
75 checks passed
@tommasini tommasini deleted the fix/remove-sentry-navigation-instrumentation branch November 11, 2024 20:49
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

@MarioAslau MarioAslau MarioAslau approved these changes

@Cal-L Cal-L Cal-L left review comments

Assignees
No one assigned
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-tiger Tiger team (for tech debt reduction + performance improvements)
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove React Navigation v5 Sentry instrumentation
6 participants
@tommasini @Cal-L @MarioAslau @EtherWizard33 @gauthierpetetin @metamaskbot