feat(2808): improvements-and-small-features-and-small-fixes-that-still-needed-to-be-added-to-edit-permissions #12168

EtherWizard33 · 2024-11-04T19:40:33Z

Description

Adding missing features, small fixes and feedback from design QA.

Related issues

Fixes:

Manual testing steps

set the feature flag export MM_MULTICHAIN_V1_ENABLED="1"
go to the dapp browser and open pancake swap and click Connect in pancake swap
change the permissions and check fixes and improvements in the commit names are present

Screenshots/Recordings

Before	After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…s not per dapp but global. This is now fixed.

github-actions · 2024-11-04T19:40:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

… rather than global

… per dapp

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

… account connected to it

…initial connection flow, this is now fixed.

… add account

…is is now fixed

…l. This is now fixed

…nfirm rather than Connect. This is now fixed.

…n android. This is now fixed.

…adding tests

github-actions · 2024-11-06T21:48:12Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9161bd8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e8495baa-3986-405f-a5c0-1370c4e007f2

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

github-actions · 2024-11-11T17:11:04Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 753dc42
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cd0382c1-4c9c-484a-9bb1-bfe8c2c94c0b

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

github-actions · 2024-11-11T18:30:59Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 64ddcf2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2825ede-3d76-447d-b93f-5c6c7ce83498

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

vinnyhoward

LGTM!🟢

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

github-actions · 2024-11-12T13:31:03Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 536d385
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcd56047-0a63-465a-a57e-c61bed565139

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2024-11-12T13:36:03Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix: the account name displayed in the footer of the tab thumbnail wa…

5121a0f

…s not per dapp but global. This is now fixed.

EtherWizard33 added team-wallet-ux No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 4, 2024

EtherWizard33 added 2 commits November 4, 2024 14:47

Merge branch 'main' into feat-2808-improvements-and-small-features-an…

7d316a6

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

test: update snapshot since the account name displayed is now per dap…

e6a8486

… rather than global

EtherWizard33 changed the title ~~fix: the account name displayed in the footer of the tab thumbnail wa…~~ feat(2808): improvements-and-small-features-and-small-fixes-that-still-needed-to-be-added-to-edit-permissions Nov 4, 2024

EtherWizard33 added 14 commits November 4, 2024 15:54

test: update the snap since the tab now displays a differente account…

feb2d23

… per dapp

Merge branch 'temp' into ttemp

f75aa7d

Merge branch 'main' into feat-2808-improvements-and-small-features-an…

f16db44

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

feat: display the account information only if the dapp has a permited…

c396582

… account connected to it

test: update snapshots to match the previous commit

00554ae

fix: title was not showing on edit account screen when used from the …

5facb1a

…initial connection flow, this is now fixed.

feat: add space between the update button and the button link used to…

96afeee

… add account

feat: space around the Connect accounts title was not as expected, th…

d760443

…is is now fixed

fix: vertical spacing between bottom buttons and content was too smal…

394340b

…l. This is now fixed

fix: in the context of a network switch, the button should display Co…

e46df27

…nfirm rather than Connect. This is now fixed.

test: update the snapshot since styles were updated

a996111

style: remove unnecessary prop

1bf452e

fix: button was truncated at the bottom of the network edit screen, o…

d816efc

…n android. This is now fixed.

style: exclude from coverage until we are feature-complete and start …

9161bd8

…adding tests

EtherWizard33 marked this pull request as ready for review November 6, 2024 21:47

EtherWizard33 requested review from a team as code owners November 6, 2024 21:47

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed No QA Needed Apply this label when your PR does not need any QA effort. labels Nov 6, 2024

Merge branch 'main' into feat-2808-improvements-and-small-features-an…

753dc42

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024

Merge branch 'main' into feat-2808-improvements-and-small-features-an…

64ddcf2

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 11, 2024

tommasini approved these changes Nov 11, 2024

View reviewed changes

vinnyhoward approved these changes Nov 11, 2024

View reviewed changes

Merge branch 'main' into feat-2808-improvements-and-small-features-an…

536d385

…d-small-fixes-that-still-needed-to-be-added-to-edit-permissions

EtherWizard33 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 12, 2024

EtherWizard33 added this pull request to the merge queue Nov 12, 2024

Merged via the queue into main with commit 89efabe Nov 12, 2024
43 checks passed

EtherWizard33 deleted the feat-2808-improvements-and-small-features-and-small-fixes-that-still-needed-to-be-added-to-edit-permissions branch November 12, 2024 14:13

github-actions bot locked and limited conversation to collaborators Nov 12, 2024

metamaskbot added the release-9.100.91 label Nov 12, 2024

gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(2808): improvements-and-small-features-and-small-fixes-that-still-needed-to-be-added-to-edit-permissions #12168

feat(2808): improvements-and-small-features-and-small-fixes-that-still-needed-to-be-added-to-edit-permissions #12168

EtherWizard33 commented Nov 4, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 11, 2024 •

edited by metamaskbot

Loading

vinnyhoward left a comment

github-actions bot commented Nov 12, 2024 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Nov 12, 2024

feat(2808): improvements-and-small-features-and-small-fixes-that-still-needed-to-be-added-to-edit-permissions #12168

feat(2808): improvements-and-small-features-and-small-fixes-that-still-needed-to-be-added-to-edit-permissions #12168

Conversation

EtherWizard33 commented Nov 4, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 6, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Nov 11, 2024 • edited by metamaskbot Loading

Bitrise

github-actions bot commented Nov 11, 2024 • edited by metamaskbot Loading

Bitrise

vinnyhoward left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 12, 2024 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Nov 12, 2024

Quality Gate passed

github-actions bot commented Nov 6, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 11, 2024 •

edited by metamaskbot

Loading

github-actions bot commented Nov 12, 2024 •

edited by metamaskbot

Loading