Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove SmokeNotifications tests for android on smoke tests pipeline #12166

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

chrisleewilcox
Copy link
Contributor

@chrisleewilcox chrisleewilcox commented Nov 4, 2024

Description

We have been getting consistent failures for smoke notifications tests on android. Will temporarily remove until flaky tests have been resolved.

https://app.bitrise.io/build/dc2115fb-a308-4514-ba85-6fa42df8b3d1?tab=tests

Related issues

Fixes: #https://github.com/MetaMask/mobile-planning/issues/2033

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pipeline showing smoke notifications tests are not ran: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7865bd78-af6f-4d84-b538-92eed03d72d8?tab=workflows

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chrisleewilcox chrisleewilcox requested review from a team as code owners November 4, 2024 19:02
Copy link
Contributor

github-actions bot commented Nov 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chrisleewilcox chrisleewilcox requested review from a team November 4, 2024 19:03
@chrisleewilcox chrisleewilcox changed the title chore: remove smokenotifications for android fix: remove SmokeNotifications tests for android on smoke tests pipeline Nov 4, 2024
@chrisleewilcox chrisleewilcox added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 4, 2024
Copy link

sonarqubecloud bot commented Nov 4, 2024

@chrisleewilcox chrisleewilcox removed the request for review from a team November 4, 2024 19:14
@chrisleewilcox chrisleewilcox added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit b50649b Nov 4, 2024
51 of 53 checks passed
@chrisleewilcox chrisleewilcox deleted the test/remove-smokenotifications branch November 4, 2024 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants