Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable smart transactions for new users #12148

Merged
merged 8 commits into from
Nov 19, 2024
Merged

feat: Enable smart transactions for new users #12148

merged 8 commits into from
Nov 19, 2024
+90 −1,131

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 1, 2024 •
edited
Loading

Description

This PR:

Related issues

Fixes:

Manual testing steps

  1. After installing the app a user will not see the STX opt in modal
  2. In Advanced Settings Smart Transactions will be on. A user can turn them off if they want

Screenshots/Recordings

Smart Transactions enabled by default in Advanced settings for new users:
image

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Nov 1, 2024
@dan437 dan437 requested review from a team as code owners November 1, 2024 13:23
@dan437 dan437 requested a review from infiniteflower November 1, 2024 13:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 marked this pull request as draft November 1, 2024 13:24
@dan437 dan437 force-pushed the enable-stx-for-new-users branch from fce2615 to b6f44c3 Compare November 1, 2024 13:33
@dan437 dan437 force-pushed the enable-stx-for-new-users branch from b6f44c3 to fae3496 Compare November 11, 2024 14:18
@dan437 dan437 marked this pull request as ready for review November 11, 2024 14:19
@dan437 dan437 requested a review from a team as a code owner November 11, 2024 14:19
@socket-security Socket Security
Copy link

socket-security bot commented Nov 11, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/preferences-controller@13.3.0 None 0 139 kB metamaskbot

🚮 Removed packages: npm/@metamask/preferences-controller@13.1.0

View full report↗︎

@dan437 dan437 force-pushed the enable-stx-for-new-users branch from fae3496 to 69121fd Compare November 12, 2024 10:55
@dan437 dan437 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 69121fd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db986bf7-b77b-4b88-90df-5e0e70d84b7e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dan437 dan437 requested a review from a team as a code owner November 12, 2024 13:16
@dan437 dan437 force-pushed the enable-stx-for-new-users branch from f2c0fc0 to 5ea5cfa Compare November 12, 2024 13:54
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 03f6744
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccb5571a-cada-4ed1-a448-e9e31b3bd3d1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cryptodev-2s cryptodev-2s mentioned this pull request Nov 13, 2024
Closed
7 tasks
@cryptodev-2s cryptodev-2s force-pushed the enable-stx-for-new-users branch from 03f6744 to e50fe6e Compare November 13, 2024 05:04
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: e50fe6e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e73ddac-29fa-40b3-a63b-4e4134bd14f0

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the enable-stx-for-new-users branch from e50fe6e to db4f3ae Compare November 13, 2024 05:06
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: db4f3ae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/238ec7c9-4b34-4629-9403-33952855ebdc

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s force-pushed the enable-stx-for-new-users branch from db4f3ae to a9e9d71 Compare November 13, 2024 05:21
@cryptodev-2s cryptodev-2s removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 13, 2024
@dan437 dan437 enabled auto-merge November 14, 2024 20:09
@dan437 dan437 force-pushed the enable-stx-for-new-users branch from c2e82a4 to 19ef539 Compare November 15, 2024 07:45
@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 19ef539
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d1f386c3-3aa5-40ff-b175-cf2811821fd9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dan437 dan437 force-pushed the enable-stx-for-new-users branch from 19ef539 to 1e44728 Compare November 15, 2024 17:45
@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1e44728
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea4599d0-b73a-4742-98b0-ed6244e73be2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

boneskull
boneskull approved these changes Nov 15, 2024
View reviewed changes
Copy link

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything concerning here

@dan437 dan437 force-pushed the enable-stx-for-new-users branch from 1e44728 to 36459a7 Compare November 19, 2024 08:15
@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 36459a7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4483de53-8be0-4d53-b0ff-e2f718abeed3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dan437 dan437 added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 1bfc731 Nov 19, 2024
43 checks passed
@dan437 dan437 deleted the enable-stx-for-new-users branch November 19, 2024 14:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EtherWizard33 EtherWizard33 EtherWizard33 approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@boneskull boneskull boneskull approved these changes

Assignees
No one assigned
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dan437 @codecov-commenter @boneskull @chrisleewilcox @infiniteflower @EtherWizard33 @metamaskbot @cryptodev-2s