Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add staking events #12144

Merged
merged 5 commits into from
Nov 5, 2024
Merged

feat: add staking events #12144

merged 5 commits into from
Nov 5, 2024

Conversation

jclancy93
Copy link
Contributor

@jclancy93 jclancy93 commented Oct 31, 2024 •
edited
Loading

Description

Adds support for events:

  • Review Stake Button Clicked
  • Unstake Button Clicked
  • Input Amount Clicked
  • Withdraw Button Clicked
  • Claim button clicked
  • Learn More Clicked

Related issues

Fixes: https://consensyssoftware.atlassian.net/jira/software/projects/STAKE/boards/550?selectedIssue=STAKE-837

Manual testing steps

Manual testing not possible right now due to events bug

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jclancy93 jclancy93 changed the base branch from main to develop October 31, 2024 23:20
@jclancy93 jclancy93 changed the base branch from develop to main October 31, 2024 23:22
amitabh94
amitabh94 reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@amitabh94 amitabh94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments but overall LGTM!

app/components/UI/Stake/Views/StakeInputView/StakeInputView.tsx Outdated Show resolved Hide resolved
app/components/UI/Stake/components/StakingBalance/StakingCta/StakingCta.tsx Outdated Show resolved Hide resolved
app/components/UI/Stake/components/StakingBalance/StakingButtons/StakingButtons.tsx Outdated Show resolved Hide resolved
app/components/UI/Stake/components/StakingBalance/StakingButtons/StakingButtons.tsx Outdated Show resolved Hide resolved
@amitabh94 amitabh94 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 965ea18
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8d7c6356-8f55-4191-8d0d-b4b47080e7ff

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 5, 2024
@jclancy93 jclancy93 marked this pull request as ready for review November 5, 2024 14:43
@jclancy93 jclancy93 requested review from a team as code owners November 5, 2024 14:43
@jclancy93 jclancy93 enabled auto-merge November 5, 2024 14:44
@jclancy93 jclancy93 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 74f6b02
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/349ada97-4a5a-45e7-83b7-32733bd5e832

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jclancy93 jclancy93 added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 5, 2024
@jclancy93 jclancy93 added this pull request to the merge queue Nov 5, 2024
@jclancy93 jclancy93 removed this pull request from the merge queue due to a manual request Nov 5, 2024
@jclancy93 jclancy93 enabled auto-merge November 5, 2024 15:12
@jclancy93 jclancy93 added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit dd574d7 Nov 5, 2024
46 checks passed
@jclancy93 jclancy93 deleted the jc/EARN-837-analytics-events branch November 5, 2024 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 5, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@amitabh94 amitabh94 amitabh94 approved these changes

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jclancy93 @amitabh94 @tommasini @metamaskbot