Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update staking eligibility and unstaking time details #12138

Merged
merged 12 commits into from
Nov 1, 2024

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Oct 31, 2024

Description

This PR introduces several updates to improve the staking experience by simplifying eligibility checks, updating messaging for geo-blocked users, and refining information on unstaking times. Key changes include:

Eligibility Checks:

  • Removed the staking eligibility check from the StakingEarnings component.
  • Simplified the eligibility logic for pooled staking in the StakingBalance component.

Geo-Block Messaging:

  • Updated banner severity to info for geo-blocked messages, offering a more appropriate visual cue.

Unstaking Time Updates:

  • Added UnstakingTimeCard component to StakeConfirmationView to provide clear, centralized information on unstaking.
  • Updated the tooltip and descriptions across relevant components to reflect accurate processing times for flexible unstaking.

Related issues

Fixes: STAKE-851, STAKE-852,STAKE-853

Manual testing steps

  1. Set the variable MM_POOLED_STAKING_UI_ENABLED = true in .js.env file
  2. Go to Ethereum details page.
  3. You should see staked balance and your earnings irrespective of the region you are in .

Screenshots/Recordings

Before

image

After

image

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 31, 2024
@amitabh94 amitabh94 marked this pull request as ready for review October 31, 2024 22:37
@amitabh94 amitabh94 requested review from a team as code owners October 31, 2024 22:37
@amitabh94 amitabh94 enabled auto-merge October 31, 2024 22:37
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 369e861
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/15c89051-dd2a-422e-af81-9368b43a5fdb

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitabh94 amitabh94 added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 88ef536 Nov 1, 2024
37 checks passed
@amitabh94 amitabh94 deleted the STAKE-853--fe-remove-estimated-changes-section branch November 1, 2024 15:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024
@amitabh94 amitabh94 removed the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024
@amitabh94 amitabh94 added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants