Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move files to Settings folder #12135

Merged
merged 8 commits into from
Nov 1, 2024

Conversation

SamuelSalas
Copy link
Contributor

@SamuelSalas SamuelSalas commented Oct 31, 2024

Description

We currently have a few of our page object files lingering outside of a specific folder. As part of our ongoing efforts to improve the organization and maintainability of our test automation codebase, we need to move Page Object files into their respective folders. This will help streamline the project structure, making it easier for team members to locate and manage the files. The folder where each of the remaining files should be moved have to reflect the functionality or feature on the app. This same structure should be reflected on the selectors folder.

Files to relocate to the Settings folder:

  • e2e/pages/modals/AutoLockModal.js
  • e2e/pages/modals/DeleteContactModal.js
  • e2e/pages/modals/DeleteWalletModal.js
  • e2e/pages/modals/FiatOnTestnetsModal.js
  • e2e/pages/modals/SrpQuizModal.js

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Regression: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/69b40802-723a-4d8f-9282-19eef5a5ce22?tab=workflows
Appium: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/74059856-9aca-41b0-8a45-058787f10b5c?tab=workflows

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise Detox area-qa Relating to QA work (Quality Assurance) labels Oct 31, 2024
@SamuelSalas SamuelSalas self-assigned this Oct 31, 2024
@SamuelSalas SamuelSalas requested review from a team as code owners October 31, 2024 21:39
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 169d464
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0a830adc-5bcd-48d8-b1a7-b1008c0c0f28

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1249371
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/57820d30-1ff4-4f6a-825d-f8b508f622f3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@SamuelSalas SamuelSalas added this pull request to the merge queue Nov 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024
@SamuelSalas SamuelSalas added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit d85cf48 Nov 1, 2024
37 checks passed
@SamuelSalas SamuelSalas deleted the test/2004-e2e-move-files-to-settings-folder branch November 1, 2024 02:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) Detox release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants