Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert the nvm update #12125

Merged
merged 3 commits into from
Oct 31, 2024
Merged

fix: revert the nvm update #12125

merged 3 commits into from
Oct 31, 2024

Conversation

sethkfman
Copy link
Contributor

Description

This PR reverts the nvm updates.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman requested a review from a team as a code owner October 31, 2024 16:31
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed team-mobile-platform labels Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0efbb52
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/268a1eef-03ac-4832-899c-e082f8ab190a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sethkfman sethkfman requested review from a team as code owners October 31, 2024 16:42
@sethkfman sethkfman merged commit 63d1205 into release/7.34.0 Oct 31, 2024
29 of 30 checks passed
@sethkfman sethkfman deleted the fix/build-revert-nvm branch October 31, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant