Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade assets-controllers to v38 #12116

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Oct 31, 2024

Description

Upgrades assets-controllers to v38
Also adds a patch for : https://github.com/MetaMask/core/pull/4821/files#diff-3336d65a4d2c1e5af90f22e16feb058f327960796b135308bca9ed8415418f5d

Related issues

Fixes:
Related to: https://github.com/MetaMask/core/pull/4821/files#diff-3336d65a4d2c1e5af90f22e16feb058f327960796b135308bca9ed8415418f5d

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added team-assets Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 020afae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0ba9594-9dfd-442b-802a-2c3dd819eb34

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

socket-security bot commented Oct 31, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@38.3.0 None +2 2.05 MB metamaskbot
npm/@metamask/polling-controller@10.0.1 None 0 107 kB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@37.0.0, npm/@metamask/polling-controller@9.0.1

View full report↗︎

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.56%. Comparing base (ead35c4) to head (020afae).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12116      +/-   ##
==========================================
+ Coverage   55.35%   55.56%   +0.21%     
==========================================
  Files        1767     1780      +13     
  Lines       39841    40065     +224     
  Branches     4965     4993      +28     
==========================================
+ Hits        22052    22261     +209     
- Misses      16274    16281       +7     
- Partials     1515     1523       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated Show resolved Hide resolved
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024
@sahar-fehri sahar-fehri marked this pull request as ready for review October 31, 2024 10:58
@sahar-fehri sahar-fehri requested review from a team as code owners October 31, 2024 10:58
Copy link
Contributor

github-actions bot commented Oct 31, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c9957f2
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/78e7d976-0b2a-45af-bde3-6a12aaf39e71

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 31, 2024
Copy link
Contributor

@Daniel-Cross Daniel-Cross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sahar-fehri sahar-fehri added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 771100f Nov 1, 2024
49 checks passed
@sahar-fehri sahar-fehri deleted the chore/upgrade-assets-controllers-v38.0.0 branch November 1, 2024 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants