-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade assets-controllers to v38 #12116
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Bitrise✅✅✅ Commit hash: 020afae Note
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/assets-controllers@37.0.0, npm/@metamask/polling-controller@9.0.1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12116 +/- ##
==========================================
+ Coverage 55.35% 55.56% +0.21%
==========================================
Files 1767 1780 +13
Lines 39841 40065 +224
Branches 4965 4993 +28
==========================================
+ Hits 22052 22261 +209
- Misses 16274 16281 +7
- Partials 1515 1523 +8 ☔ View full report in Codecov by Sentry. |
Bitrise✅✅✅ Commit hash: c9957f2 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
Upgrades assets-controllers to v38
Also adds a patch for : https://github.com/MetaMask/core/pull/4821/files#diff-3336d65a4d2c1e5af90f22e16feb058f327960796b135308bca9ed8415418f5d
Related issues
Fixes:
Related to: https://github.com/MetaMask/core/pull/4821/files#diff-3336d65a4d2c1e5af90f22e16feb058f327960796b135308bca9ed8415418f5d
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist