Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update TransactionProtectionModal import #12112

Conversation

SamuelSalas
Copy link
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas added Appium team-mobile-platform area-qa Relating to QA work (Quality Assurance) labels Oct 30, 2024
@SamuelSalas SamuelSalas self-assigned this Oct 30, 2024
@SamuelSalas SamuelSalas requested a review from a team as a code owner October 30, 2024 22:42
…electors-reference-on-transactionprotectionmodaljs
…electors-reference-on-transactionprotectionmodaljs
@SamuelSalas SamuelSalas added No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. labels Oct 31, 2024
Copy link

@SamuelSalas SamuelSalas added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 4907688 Oct 31, 2024
41 of 43 checks passed
@SamuelSalas SamuelSalas deleted the fix/12111-appium-transactionprotectionmodalselectors-reference-on-transactionprotectionmodaljs branch October 31, 2024 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Appium area-qa Relating to QA work (Quality Assurance) No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix appium TransactionProtectionModal.selectors reference on TransactionProtectionModal.js
3 participants