Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runway): cherry-pick ci: Update bitrise machines #12106

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

runway-github[bot]
Copy link
Contributor

@runway-github runway-github bot commented Oct 30, 2024

Description

Currently our e2e pipelines are failing due to Invalid default machine type g2-m1-max.5core. The purpose of this PR is to update the mac
machine to g2.mac.large

Associated build run:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/96299a39-cfa7-412e-b7ad-524d0bd27465?tab=workflows

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. b708d55

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Currently our e2e pipelines are failing due to `Invalid default machine
type g2-m1-max.5core`. The purpose of this PR is to update the mac
machine to `g2.mac.large`


Associated build run:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/96299a39-cfa7-412e-b7ad-524d0bd27465?tab=workflows

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github bot requested review from a team as code owners October 30, 2024 17:38
@sethkfman sethkfman merged commit 3c45a6c into release/7.33.1 Oct 30, 2024
27 of 29 checks passed
@sethkfman sethkfman deleted the runway-cherry-pick-7.33.1-1730309962 branch October 30, 2024 17:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants