Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automate build versions #12098

Merged
merged 7 commits into from
Oct 31, 2024
Merged

feat: automate build versions #12098

merged 7 commits into from
Oct 31, 2024

Conversation

jake-perkins
Copy link
Contributor

@jake-perkins jake-perkins commented Oct 30, 2024

Description

  1. The reason for this change is to eliminate the manual management of the build version for the metamask mobile application. This PR externalizes all interactions surrounding the build version to a GH Action/Workflow that leverages an external table to be the "source of truth" for the build version. Developers will not need to coordinate with one another to increment the build version.

  2. Modularize few scripts and remove un-used / previously deprecated scripts

Related issues

[Fixes:]

https://github.com/MetaMask/mobile-planning/issues/1795

Manual testing steps

The versioning scripts can be run and tested locally now running the following

./scripts/set-semvar-version.sh 7.34.0
./scripts/set-build-version.sh 1480

Unfortunately the new shared workflow will essentially need to be tested on the main branch due to github restrictions.
However the observed new github action can be viewed in the following test repository for an idea of the end to end flow/interaction - https://github.com/MetaMask/temp-gh-action-testing/actions/runs/11509429811/job/32089330279

which will simulate updating the appropriate configuration files for the pipeline

Screenshots/Recordings

Before

N/A - no actual app changes only CICD

After

N/A - no actual app changes only CICD

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jake-perkins jake-perkins requested a review from a team as a code owner October 30, 2024 03:21
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-dev-ops DevOps team label Oct 30, 2024
@jake-perkins jake-perkins added the No QA Needed Apply this label when your PR does not need any QA effort. label Oct 30, 2024
tommasini
tommasini previously approved these changes Oct 30, 2024
tommasini
tommasini previously approved these changes Oct 30, 2024
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jake-perkins jake-perkins added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 55a73a5 Oct 31, 2024
37 checks passed
@jake-perkins jake-perkins deleted the build-version-automation branch October 31, 2024 21:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.35.0 Issue or pull request that will be included in release 7.35.0 team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants