-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automate build versions #12098
Merged
Merged
+292
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jake-perkins
added
the
No QA Needed
Apply this label when your PR does not need any QA effort.
label
Oct 30, 2024
tommasini
previously approved these changes
Oct 30, 2024
tommasini
previously approved these changes
Oct 30, 2024
sethkfman
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
metamaskbot
added
the
release-7.35.0
Issue or pull request that will be included in release 7.35.0
label
Oct 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
No QA Needed
Apply this label when your PR does not need any QA effort.
release-7.35.0
Issue or pull request that will be included in release 7.35.0
team-dev-ops
DevOps team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reason for this change is to eliminate the manual management of the build version for the metamask mobile application. This PR externalizes all interactions surrounding the build version to a GH Action/Workflow that leverages an external table to be the "source of truth" for the build version. Developers will not need to coordinate with one another to increment the build version.
Modularize few scripts and remove un-used / previously deprecated scripts
Related issues
[Fixes:]
https://github.com/MetaMask/mobile-planning/issues/1795
Manual testing steps
The versioning scripts can be run and tested locally now running the following
./scripts/set-semvar-version.sh 7.34.0
./scripts/set-build-version.sh 1480
Unfortunately the new shared workflow will essentially need to be tested on the main branch due to github restrictions.
However the observed new github action can be viewed in the following test repository for an idea of the end to end flow/interaction - https://github.com/MetaMask/temp-gh-action-testing/actions/runs/11509429811/job/32089330279
which will simulate updating the appropriate configuration files for the pipeline
Screenshots/Recordings
Before
N/A - no actual app changes only CICD
After
N/A - no actual app changes only CICD
Pre-merge author checklist
Pre-merge reviewer checklist