chore(runway): cherry-pick fix(11895): remove duplicate networks in incoming transactions settings #12096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=60&v=4){kind=small}
…ncoming transactions settings (#12016) ## **Description** We now list `mainnet` networks in the `rpcEndpoints` so the previous logic rendering `mainnet` in separate functions are no longer need. Here is the relevant [PR](https://github.com/MetaMask/metamask-mobile/pull/11705/files) that has those changes. The `rpcEndpoints` do not render in the right order so filtering by Linea Mainnet and Ethereum Mainnet is needed. ## **Related issues** Related Issue: [#11895](#11895) ## **Manual testing steps** 1. Go to this settings page 2. Click on "Security & Privacy" 3. Scroll down and toggle "Show incoming transactions" and confirm that it works 4. Confirm that the duplicate `mainnet` networks are gone ## **Screenshots/Recordings**  | Before | After |:---:|:---:| ||| ### **Before** NA ### **After** NA ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
NicolasMassart
approved these changes
Oct 30, 2024
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We now list
mainnetnetworks in therpcEndpointsso the previouslogic rendering
mainnetin separate functions are no longer need. Hereis the relevant
PR that
has those changes. The
rpcEndpointsdo not render in the right orderso filtering by Linea Mainnet and Ethereum Mainnet is needed.
Related issues
Related Issue:
#11895
Manual testing steps
it works
mainnetnetworks are goneScreenshots/Recordings
Before
NA
After
NA
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. 60bdb96