Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move files to Transactions folder #12090

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

SamuelSalas
Copy link
Contributor

@SamuelSalas SamuelSalas commented Oct 29, 2024

Description

We currently have a few of our page object files lingering outside of a specific folder. As part of our ongoing efforts to improve the organization and maintainability of our test automation codebase, we need to move Page Object files into their respective folders. This will help streamline the project structure, making it easier for team members to locate and manage the files. The folder where each of the remaining files should be moved have to reflect the functionality or feature on the app. This same structure should be reflected on the selectors folder.

Files to relocate to the Transactions folder:

  • e2e/pages/ActivitiesView.js
  • e2e/pages/modals/AssetWatchModal.js
  • e2e/pages/modals/DetailsModal.js
  • e2e/pages/modals/TransactionProtectionModal.js

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Regression Test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/351abd6d-5c24-4a30-beed-f847d7d66892?tab=workflows

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@SamuelSalas SamuelSalas added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise Detox area-qa Relating to QA work (Quality Assurance) labels Oct 29, 2024
@SamuelSalas SamuelSalas self-assigned this Oct 29, 2024
@SamuelSalas SamuelSalas requested review from a team as code owners October 29, 2024 22:56
Copy link
Contributor

github-actions bot commented Oct 29, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4ed8541
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5d29c9cd-ef8e-4857-9613-4592fc1becc7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: eab0656
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7436d96d-297a-491d-a4ea-2df962d423b7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

e2e/pages/Transactions/DetailsBottomSheet.js Outdated Show resolved Hide resolved
@SamuelSalas SamuelSalas added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7d3ff90
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f99f87e3-16bb-4fcd-a871-ed6b893c9b7c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@SamuelSalas SamuelSalas added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit f54acb6 Oct 30, 2024
43 checks passed
@SamuelSalas SamuelSalas deleted the test/2006-e2e-move-files-to-transactions-folder branch October 30, 2024 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-qa Relating to QA work (Quality Assurance) Detox release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants