Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Contacts disappearing #12089

Merged
merged 4 commits into from
Oct 30, 2024
Merged

fix: Contacts disappearing #12089

merged 4 commits into from
Oct 30, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Oct 29, 2024 •
edited by NicolasMassart
Loading

Description

Fix for address book controller state (contacts) be populated when initialise if data is persisted.

Build APK for test upgrade: https://app.bitrise.io/build/56fd9c34-7024-4478-abf9-4d27a8dd035c?tab=log

Related issues

Fixes #12044

Manual testing steps

  1. Installed 7.32.0
  2. imported wallet
  3. added contact
  4. updated to 7.34.0 apk with fix: https://app.bitrise.io/build/56fd9c34-7024-4478-abf9-4d27a8dd035c?tab=log
  5. the contact is still there

Screenshots/Recordings

Before

After

Screen.Recording.2024-10-29.at.23.25.33.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: da636b8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6126dbf-1716-4c54-8a2a-d223b9da4ff6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Cal-L
Cal-L previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommasini tommasini marked this pull request as ready for review October 29, 2024 23:28
@tommasini tommasini requested review from a team as code owners October 29, 2024 23:28
@tommasini tommasini added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6772019
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c54db670-ccb8-4a8c-b76f-ceb16bb9160e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Cal-L
Cal-L approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tommasini tommasini enabled auto-merge October 29, 2024 23:46
@tommasini tommasini added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 7c4fa63 Oct 30, 2024
42 of 43 checks passed
@tommasini tommasini deleted the fix/899-addresses-saved branch October 30, 2024 00:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 30, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 30, 2024
@NicolasMassart NicolasMassart added release-7.34.0 and removed release-7.35.0 Issue or pull request that will be included in release 7.35.0 labels Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees
No one assigned
Labels
release-7.34.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Saved contacts erased after restarting the app
4 participants
@tommasini @Cal-L @NicolasMassart @metamaskbot