chore(runway): cherry-pick feat: add favorites to browser menu #12078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![runway-github[bot]](https://avatars.githubusercontent.com/in/86225?s=60&v=4){kind=small}
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> We're adding in a "Go to Favorites" option into the browser menu so users can navigate to https://home.metamask.io, allowing them to access their previous favorites pages. After switching to the Portfolio dapps for a user's homepage, we received a decent amount of user feedback wanting this feature back in. ## **Related issues** Fixes: ## **Manual testing steps** 1. Open the in-app browser 2. Navigate to any website that's not https://home.metamask.io 3. Open the browser menu by tapping on the "more" icon 4. See the new "Go to Favorites" option, tap that. 5. Confirm that the user is taken to https://home.metamask.io ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before**  ### **After**  Actual https://github.com/user-attachments/assets/e6aabfd6-3746-4075-ad47-b8140afbc3fd <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Signed-off-by: Kai Huang <kai.huang@consensys.net> Co-authored-by: Cal-L <cleun007@gmail.com> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com> Co-authored-by: Cal Leung <cal.leung@consensys.net>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
sethkfman
added
No QA Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're adding in a "Go to Favorites" option into the browser menu so
users can navigate to https://home.metamask.io, allowing them to access
their previous favorites pages. After switching to the Portfolio dapps
for a user's homepage, we received a decent amount of user feedback
wanting this feature back in.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Actual
favorite.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Signed-off-by: Kai Huang kai.huang@consensys.net
Co-authored-by: Cal-L cleun007@gmail.com
Co-authored-by: legobeat 109787230+legobeat@users.noreply.github.com
Co-authored-by: Cal Leung cal.leung@consensys.net 36d2535