Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix naming for linea and mainnet #12074

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix: fix naming for linea and mainnet #12074

merged 3 commits into from
Oct 29, 2024

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 29, 2024 •
edited
Loading

Description

The network names for Ethereum mainnet and Linea mainnet should be standardized as "Ethereum Mainnet" and "Linea" to align with our third-party provider.

core PR: adjust network names

Related issues

Fixes: #11895

Manual testing steps

  1. Move from v7.33 ( or any previous release version ) to this branch
  2. Check the name of Ethereum mainnet and Linea

Screenshots/Recordings

Before

Screenshot 2024-10-29 at 14 57 00

After

Screenshot 2024-10-29 at 14 56 53

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2a5d508
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e6298759-cb8d-4469-849e-ee2ea630f310

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb force-pushed the salim/fix-mainnet-linea-naming branch from 2a5d508 to 454469e Compare October 29, 2024 13:33
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@salimtb salimtb marked this pull request as ready for review October 29, 2024 13:40
@salimtb salimtb requested review from a team as code owners October 29, 2024 13:40
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@MetaMask MetaMask deleted a comment from github-actions bot Oct 29, 2024
@salimtb salimtb added regression-RC-7.34 Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 454469e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/970e792e-c492-4fc7-b4dd-3be51196748a

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

chrisleewilcox
chrisleewilcox approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@salimtb salimtb added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 627ed0c Oct 29, 2024
37 checks passed
@salimtb salimtb deleted the salim/fix-mainnet-linea-naming branch October 29, 2024 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 29, 2024
@gauthierpetetin gauthierpetetin added regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 and removed regression-RC-7.34 labels Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@cryptotavares cryptotavares cryptotavares approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

Assignees
No one assigned
Labels
regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Ethereum Mainnet name is displayed as Mainnet on Android
6 participants
@salimtb @chrisleewilcox @cryptotavares @vinnyhoward @gauthierpetetin @metamaskbot