Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix assets detail page crash #12064

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Oct 29, 2024

Description

After tapping a send token deeplink and cancelling the send on Confirm screen the token to send is added to wallet account and displayed on token list. Tokens that are auto-added by a deeplink will crash app on Token Details view, even if the Token was already imported before tapping deeplink.

Send token deeplink: https://metamask.app.link/send/0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48@1/transfer?address=0x2990079bcdEe240329a520d2444386FC119da21a&uint256=2.5e7

Related issues

Fixes: #11984

Manual testing steps

  1. Go to the wallet page
  2. Click on the link on the description outside of the app
  3. go to token details page

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb added team-assets needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Oct 29, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb salimtb added regression-RC-7.34 Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: e47493d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2c3c9194-cd29-4cd1-bc85-369d89accbf7

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@salimtb salimtb marked this pull request as ready for review October 29, 2024 08:00
@salimtb salimtb requested a review from a team as a code owner October 29, 2024 08:00
@salimtb salimtb force-pushed the salim/fix-assets-detail-page branch from e47493d to 06cf54b Compare October 29, 2024 08:01
@salimtb salimtb force-pushed the salim/fix-assets-detail-page branch from 06cf54b to f497048 Compare October 29, 2024 08:06
@salimtb salimtb added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 29, 2024
Copy link
Contributor

github-actions bot commented Oct 29, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f497048
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82562014-7946-440b-bffa-34b39d8eadd7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

@salimtb salimtb added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 088a426 Oct 29, 2024
43 checks passed
@salimtb salimtb deleted the salim/fix-assets-detail-page branch October 29, 2024 09:27
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 29, 2024
@gauthierpetetin gauthierpetetin added regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 and removed regression-RC-7.34 labels Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. regression-RC-7.34.0 Regression bug that was found in release candidate (RC) for release 7.34.0 release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Token added to wallet after tapping send token deeplink, app crash on Token Details
4 participants