Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor engine helpers to handle push notifications - 2/3 #12045

Merged
merged 13 commits into from
Nov 4, 2024

Conversation

Jonathansoufer
Copy link
Contributor

Description

This PR aims to be based on 12028, and brings some refactoring on Engine and hooks to handle push notifications and user storage retrieval. There's no UI change on this PR.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Jonathansoufer Jonathansoufer added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise team-notifications Notifications team labels Oct 28, 2024
@Jonathansoufer Jonathansoufer self-assigned this Oct 28, 2024
@Jonathansoufer Jonathansoufer requested review from a team as code owners October 28, 2024 10:45
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a30efe4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6da37ea9-022b-4722-a5d1-846081bb3b6b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Jonathansoufer Jonathansoufer added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: e4c6f45
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/94d5afd6-6dee-4011-bf7b-2d769024f7d0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Nov 1, 2024

@Jonathansoufer Jonathansoufer added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 00a91ce Nov 4, 2024
43 checks passed
@Jonathansoufer Jonathansoufer deleted the NOTIFY-1219/refactor-engine-helpers branch November 4, 2024 09:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 4, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform team-notifications Notifications team team-snaps-platform Snaps Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants