Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(devDeps): detox@20.27.2->^20.27.5 #12039

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore(devDeps): detox@20.27.2->^20.27.5 #12039

merged 1 commit into from
Oct 28, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 28, 2024

Description

  • bump detox
  • migrate detox patch
    Silence patch-package setup warning

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Oct 28, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/detox-copilot@0.0.23 eval, filesystem 0 32.5 kB asafkorem
npm/detox@20.27.5 Transitive: filesystem, network +4 13.4 MB wix.mobile

🚮 Removed packages: npm/detox-copilot@0.0.9, npm/detox@20.27.2

View full report↗︎

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security and removed team-lavamoat labels Oct 28, 2024
@legobeat legobeat marked this pull request as ready for review October 28, 2024 04:11
@legobeat legobeat requested review from a team as code owners October 28, 2024 04:11
- chore: migrate detox patch
Copy link

@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d83ffea
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0e0a6d41-f953-4097-8107-9062a1a16ad8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! ty for addressing 🌮

@legobeat legobeat added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 1f5f852 Oct 28, 2024
39 of 40 checks passed
@legobeat legobeat deleted the devdeps-detox branch October 28, 2024 21:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
@metamaskbot metamaskbot added the release-7.35.0 Issue or pull request that will be included in release 7.35.0 label Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-7.35.0 Issue or pull request that will be included in release 7.35.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants